Exporter les membres d'un salon dans un fichier csv #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add tab to download csv file of the list of users in a room * Put download file in tchap utils, and change csv to txt donwload * Add tooltip
aulamber
force-pushed
the
add-tab-to-download-csv-file-of-the-list-of-users-in-a-room
branch
from
21902ba
to
18cc90f
Compare
odelcroi
changed the title
…-list-of-users-in-a-room
|
Code written. Tests coming. Changes :
Francais : When button is clicked : Anglais When button is clicked :
|
odelcroi
approved these changes
Aug 28, 2023
| }); | ||
| }); | ||
|
|
||
| it("downloads the file when button is clicked", () => { |
| }; | ||
| + | ||
| + /* TCHAP */ | ||
| + private onExportButtonClick = (ev: ButtonEvent): void => { |
There was a problem hiding this comment.
along with the button, could it have been a separated component to aliviate the patch footprint?
|
wonderful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cf. #593